Template talk:Hero table row: Difference between revisions
Jump to navigation
Jump to search
(If empty) |
mNo edit summary |
||
| (10 intermediate revisions by 4 users not shown) | |||
| Line 1: | Line 1: | ||
== | Could we possibly remove the source parameter when the expansion column is enabled? I know it'd remove the map editor icon too, but that could be fixed by having source1 and source2 as parameters instead of just source, in which case: the expansion column being enabled would disable source1 (the expansion icon) but keep source2 (the map/campaign editor icon) enabled. It's a bit complex but that's the only way I can think of having both templates combined into one without repeating information. [[File:Hero Cosmos small.gif|link=user:phasma|→ Phasma]] 19:06, 1 October 2024 (UTC) | ||
* They do slightly different things. The exp= parameter shows the map icon, and the source= parameter shows/hides the rows. exp=hota should always be paired with source=hota, but that is not true for sod. Unless I am misunderstanding your point? Do you instead mean the little icons by the character's name? --[[User:Legate|Legate]] ([[User talk:Legate|talk]]) 19:25, 1 October 2024 (UTC) | |||
** Yes the little icons by the names! Sorry if I didn't make it clear, I was just going by the parameter names from the table that I might have got mixed up. So yes: if the expansion column is enabled, hiding the little icon by the hero name would make sense to remove duplicate information. [[File:Hero Cosmos small.gif|link=user:phasma|→ Phasma]] 19:29, 1 October 2024 (UTC) | |||
** We may have to split up the little expansion icons from the map editor icons...I think we still want to show the map editor ones, but hide the others? --[[User:Legate|Legate]] ([[User talk:Legate|talk]]) 19:40, 1 October 2024 (UTC) | |||
** Now that I've done the work to have both flavors of the table...why don't we just always show the source column? I think the only place the non-source column is shown is on the town page. If we do this, then we could fix the tables to never show duplicate data. --[[User:Legate|Legate]] ([[User talk:Legate|talk]]) 12:31, 2 October 2024 (UTC) | |||
*** I think always showing it is a great idea, I thought you or others wanted to have it toggleable with the edits I saw but I would like to have the source column permanent! [[File:Hero Cosmos small.gif|link=user:phasma|→ Phasma]] 13:59, 2 October 2024 (UTC) | |||
*** Ok done. I think that is MUCH cleaner. I left some icons for Lord Haart/Haart Lich/Sir Mullich because there is some weirdness as to when they are available. --[[User:Legate|Legate]] ([[User talk:Legate|talk]]) 15:01, 2 October 2024 (UTC) | |||
Latest revision as of 15:01, 2 October 2024
Could we possibly remove the source parameter when the expansion column is enabled? I know it'd remove the map editor icon too, but that could be fixed by having source1 and source2 as parameters instead of just source, in which case: the expansion column being enabled would disable source1 (the expansion icon) but keep source2 (the map/campaign editor icon) enabled. It's a bit complex but that's the only way I can think of having both templates combined into one without repeating information. 
19:06, 1 October 2024 (UTC)
- They do slightly different things. The exp= parameter shows the map icon, and the source= parameter shows/hides the rows. exp=hota should always be paired with source=hota, but that is not true for sod. Unless I am misunderstanding your point? Do you instead mean the little icons by the character's name? --Legate (talk) 19:25, 1 October 2024 (UTC)
- Yes the little icons by the names! Sorry if I didn't make it clear, I was just going by the parameter names from the table that I might have got mixed up. So yes: if the expansion column is enabled, hiding the little icon by the hero name would make sense to remove duplicate information. 19:29, 1 October 2024 (UTC)
- We may have to split up the little expansion icons from the map editor icons...I think we still want to show the map editor ones, but hide the others? --Legate (talk) 19:40, 1 October 2024 (UTC)
- Now that I've done the work to have both flavors of the table...why don't we just always show the source column? I think the only place the non-source column is shown is on the town page. If we do this, then we could fix the tables to never show duplicate data. --Legate (talk) 12:31, 2 October 2024 (UTC)
- I think always showing it is a great idea, I thought you or others wanted to have it toggleable with the edits I saw but I would like to have the source column permanent! 13:59, 2 October 2024 (UTC)
- Ok done. I think that is MUCH cleaner. I left some icons for Lord Haart/Haart Lich/Sir Mullich because there is some weirdness as to when they are available. --Legate (talk) 15:01, 2 October 2024 (UTC)
- I think always showing it is a great idea, I thought you or others wanted to have it toggleable with the edits I saw but I would like to have the source column permanent!
- Yes the little icons by the names! Sorry if I didn't make it clear, I was just going by the parameter names from the table that I might have got mixed up. So yes: if the expansion column is enabled, hiding the little icon by the hero name would make sense to remove duplicate information.