Template talk:HeroClassNew
- There seems to be some issue with how the battlefield pics are aligned. They seem to be relative to the bottom of the page instead of the bottom of the hero box. This will probably break again if enough text gets added to this page...consider switching bottom aligned items to top-aligned or figure out how to make them relative to the hero box instead of the page. --Legate (talk) 18:21, 10 February 2025 (UTC)
I see that you're compartmentalising every aspect of this template but I do not think it is necessary; it worked completely fine before and I'm not sure what you're trying to accomplish by doing this - it is frustrating using templates within templates, which is what this whole new design is meant to avoid; could you enlighten me as to why you're doing this? Because now the numbers cannot be highlighted and there is a huge amount of random scrollable blank space that I eliminated by aligning text the way I did when I made this template, and to me this change just makes this template more unnecessarily complex! 
20:26, 10 February 2025 (UTC)
- Additionally, this template and its components are not being used anywhere else on this site, so there is 0 need for breaking it down; I'm trying to code things specifically so that I know they won't break with the wikitable guidelines I hope to establish with pushing H3CSS live when it's ready (aka only using them for long lists like hero tables or the list of artifacts/spells), so I urge you not to keep breaking down templates for the sake of it. I'm tailoring these so that they won't ever break with the new CSS - I have noted many more templates I'll need to remake fully WITHOUT using tables within tables and templates within templates, so keeping everything in one template saves me more fixing and headaches. 20:38, 10 February 2025 (UTC)
- Ok, no problem, you can just revert it. I lean towards doing these types of pages with templates to avoid having repeated copy-pasted code. That way, you can change a number in 1 location and it applies to all the correct locations. If you prefer to have it all in 1 page, that is no problem, I won't touch it. --Legate (talk) 20:44, 10 February 2025 (UTC)
- I do understand that for other cases, but when it's information that really is only in one place, I'd rather just keep it in that place :') the code can definitely be optimised in the future, but my main focus is getting everything working in the first place, and then go over things and optimise where possible. 20:52, 10 February 2025 (UTC)
- I do understand that for other cases, but when it's information that really is only in one place, I'd rather just keep it in that place :') the code can definitely be optimised in the future, but my main focus is getting everything working in the first place, and then go over things and optimise where possible.
- Alright - everything should be reverted now - You should add a content switch for Interference so it doesn't show in sod. --Legate (talk) 20:56, 10 February 2025 (UTC)
- Ok, no problem, you can just revert it. I lean towards doing these types of pages with templates to avoid having repeated copy-pasted code. That way, you can change a number in 1 location and it applies to all the correct locations. If you prefer to have it all in 1 page, that is no problem, I won't touch it. --Legate (talk) 20:44, 10 February 2025 (UTC)
Column Themes[edit | hide | hide all]
If the columns are meant to be might, magic, and adventure; why are Eagle Eye and Necromancy not in the Magic column?
- It was just how it was before so I didn't make any changes to it when making this new template, but I think Eagle Eye at least makes sense to be moved to Magic. Necromancy literally is magic but doesn't rely on anything magical in-game sooo it's a bit of a weird edge case? I can move it to Magic for the sake of it though, it makes logical sense to be there. 00:12, 18 February 2025 (UTC)