User talk:Imahero/sound

From Heroes 3 wiki
Jump to navigation Jump to search

Good Job![edit | hide | hide all]

Looks like you figured it out! As per Phasma's comment on the other page, is there a way to have a volume control (ideally unified between widgets somehow), or maybe just play all sound at 50% volume? --Legate (talk) 19:15, 10 September 2025 (UTC)

I set it to 50% just now. It'll take a few minutes for the change to take hold. Let me know if you need any further adjustments or tweaks. –imahero 19:28, 10 September 2025 (UTC)
Should we lower the default volume? My preference is 0.2 –imahero 20:50, 10 September 2025 (UTC)
Also yeah, it will only affect the new playables. The old stuff is controlled by the TimedMediaHandler extension which I haven't figured out how to hook into and control. –imahero 20:53, 10 September 2025 (UTC)
OK, I've got the volume control affecting the TimedMediaHandler stuff too. (As soon as you start being served v13 of common.js). Let me know how it goes. –imahero 23:06, 10 September 2025 (UTC)
OK, so it's kinda finicky. I'll see if I can improve how often it works. The code doesn't end up running some of the time. –imahero 23:08, 10 September 2025 (UTC)
OK. It should be stable now. Let me know if you ever find any audio/video that doesn't play at the volume you've set. –imahero 07:13, 11 September 2025 (UTC)
  • Awesome! Very well done, imahero! --Legate (talk) 12:44, 11 September 2025 (UTC)
    I've temporarily disabled the global tmh audio/video volume. Going to try coming up with a different approach. –imahero 16:37, 11 September 2025 (UTC)
    OK I re-enabled the global tmh volume handler. Hopefully I'll be satisfied with this result, but let me know if you encounter any issues. –imahero 19:23, 11 September 2025 (UTC)
    There should probably be some kind of always-visible title, instead of just the hove-over text. Also, I think it would also be more intuitive to most users if you displayed the value as a percent instead of a decimal. --Legate (talk) 19:41, 11 September 2025 (UTC)
    Done. Anything else? –imahero 22:24, 11 September 2025 (UTC)
    Looks great! --Legate (talk) 12:43, 12 September 2025 (UTC)