Editing Template talk:Hero

== Race ==
I think we should unlink the hero template Race from the Race page that discusses what is in the game files. We've gone back and forth a few time on the hero pages, but I think most people lean towards the race on the hero page being lore-accurate, not game-file accurate. Thoughts? --[[User:Legate|Legate]] ([[User talk:Legate|talk]]) 20:14, 7 October 2024 (UTC)
* I think that especially since hero race has absolutely no impact on gameplay (and makes you wonder why it's even in the code), we should stick to lore accuracy over code accuracy. Perhaps they had plans for race-specific features that were never added in the end... [[File:Hero Cosmos small.gif|link=user:phasma|→ Phasma]]
** Disagree with unlinking the article. It has no impact on what race is put on the hero pages anyway. --[[User:Turnam|Turnam]] ([[User talk:Turnam|talk]]) 10:11, 8 October 2024 (UTC)

== s_hota_mp ==
s_hota_mp input is doubling itself at hero pages.--[[User:GroundhogYear|GroundhogYear]] ([[User talk:GroundhogYear|talk]]) 00:19, 1 April 2020 (UTC)
: Fixed.
:: maybe there is a sense to use s_hota_mp/s_hota2_mp when min, max and hota movepoints are the same--[[User:GroundhogYear|GroundhogYear]] ([[User talk:GroundhogYear|talk]]) 01:37, 1 April 2020 (UTC)

Is there some way to make the "starting spell" thing optional or something (I assume there is, because there can be people with only one starting skill, but I wouldn't know how to do it)?  Because most might heroes don't have a starting spell at all, so "starting spell" isn't applicable to them. [[User:Ibraesil|Ibraesil]] ([[User talk:Ibraesil|talk]]) 00:42, 13 February 2016 (CET)

:As I undestand it is not possible to make it optional. Optional second secondary skill has been made with additional 'oneskill' parameter, which has to defined as empty in the article in order for it to work. In other words, you would have to add  e.g. "nospell" parameter to each article, which is basically the same amount of editing as adding the right spell parameter. This version of media wiki would support if-parameters which could help to make optional templates, but I believe it would need add-on installation to the server, which we cannot do. –[[User:Kapteeni Ruoska|Kapteeni Ruoska]] ([[User talk:Kapteeni Ruoska|talk]]) 08:03, 15 February 2016 (CET)

:Update. Now if nospell is defined, there is no gibbrish code in the text box. –[[User:Kapteeni Ruoska|Kapteeni Ruoska]] ([[User talk:Kapteeni Ruoska|talk]]) 08:18, 15 February 2016 (CET)

== Starting troops (HotA) ==

Starting troops' 3/4 and 1/4 chances are incorrect for HotA. Is it possible to just make these lines editable without creating a new template? --[[User:ShushMaster|ShushMaster]] ([[User talk:ShushMaster|talk]]) 17:18, 13 May 2018 (CEST)
* Just bringing the question up. --[[User:ShushMaster|ShushMaster]] ([[User talk:ShushMaster|talk]]) 00:30, 14 May 2018 (CEST)

** I added the variables chance_1, chance_2, and chance_3. ―[[user:imahero|imahero]] 02:48, 14 May 2018 (CEST)

== Starting troops probabilities ==
wanted to check our current 75/25 probabilities for the second/third stacks and got these results:
{| border
!+ colspan=5| 120 prison generations per hero type, SoD + HD mode</br>war machine counts as a second stack
|-
! Stacks || Ballista heroes || Tent heroes || Regular heroes || Total
|-
| 1 || 8 (6,7%) || 9 (7,5%) || 13 (10,8%) || 30 (8,3%)
|-
| 1, 2 || 83 (69,2%) || 82 (68,3%) || 82 (68,3%) || 247 (68,6%) 
|-
| 1, 3 || 4 (3,3%) || 3 (2,5%) || 2 (1,7%) || 9 (2,5%)
|-
| 1, 2, 3 || 25 (20,8%) || 26 (21,7%) || 23 (19,2%) || 74 (20,6%)
|}
since the numbers were added by Kapteeni ([[https://heroes.thelazy.net/index.php?title=Template:Hero&direction=next&oldid=27002]]), we cannot ask about sources

war machine probability was added later and is just a copy of the second stack's, i think

'tribute to strategists' says about 9/69/22 percents for heroes with 1/2/3 stacks, talking nothing about difference between 1-2 and 1-3 generations.

'fizmig' gives the same 9/69/22 but notes that 69 is a probability for both 1-2 and 1-3, not explaining the sub-probabilities though. this looks problematic personally for me, cause 69 is the only stable number from the tests and it tells about 1-2 generations only.

ofc, 1000 generations could give more precise data, but the process is too much fun, and will have not enough probative power anyway.

so im dividing the 'tribute's 22% into 20% for the 1-2-3 and 2% for 1-3 generations

resulting changes will look like:

75% > 89% (1,2 + 1,2,3)</br>
25% > 22% (1,3 + 1,2,3)

waiting for the Wise One with the source numbers from the game code --[[User:GroundhogYear|GroundhogYear]] ([[User talk:GroundhogYear|talk]]) 13:11, 22 March 2021 (UTC)

:The .exe file holds these values for the second and third stack probability: the offset 0x0C949E = 0x58 (88 in decimal) and the offset 0x0C9520 = 0x19 (25 in decimal). So, the chances for the second and the third ones are 88% and 25%  respectively --[[User:Mortarial|Mortarial]] ([[User talk:Mortarial|talk]]) 16:57, 22 March 2021 (UTC)

== Hero portrait size ==
Changed it to 58px wide aka default size to stop unwanted blurriness. Perhaps in the future, a border can be made or coded around the image if it feels too small, but for now at least they're no longer blurry. [[File:Hero Cosmos small.gif|link=special:contributions/phasma|→ Phasma]] 18:09, 31 May 2023 (UTC)
: nah, still blurry, its just not big enough to notice now.  
: [[File: Hero Adelaide.png|58px]] <span style="image-rendering: pixelated;">[[File: Hero Adelaide.png|58px]]</span> 
: [[File: Hero Adelaide.png|82px]] <span style="image-rendering: pixelated;">[[File: Hero Adelaide.png|82px]]</span><br />
: but maybe we should stick to blurriness, since a true pixel tends to hurt little children's eyes--[[User:GroundhogYear|GroundhogYear]] ([[User talk:GroundhogYear|talk]]) 06:50, 1 June 2023 (UTC)

== Problem with the "s_link" value ==

There is a problem with this link - It only affects the spell that is displayed in the table on the left but it doesn't affect the article text. For example (possibly the ONLY example), on the page of Adrienne the Witch: [[Adrienne]]. You can see that the link to the inferno spell works fine on the table to the left but the text on the article itself says "starts with a spell book and the spell Inferno" and the link to "inferno" is incorrect there. I don't know how to fix this. --[[Special:Contributions/141.226.14.115|141.226.14.115]] 06:49, 24 November 2023 (UTC)
: :) [[File:Hero Stormblessed small.gif|→ima|link=user:imahero]] 18:26, 24 November 2023 (UTC)
Thank you for fixing the problem, Imahero. --[[Special:Contributions/141.226.162.200|141.226.162.200]] 02:31, 1 December 2023 (UTC)

== HotA creature images ==

Could we add an option to use the HotA versions of creature portraits in the troops section? I'm not educated enough on templates to add this parameter, but I'd imagine it as something like ''' | troop_1_img= HotA''' [[File:Hero Cosmos small.gif|link=user:phasma|→ Phasma]] 18:57, 8 May 2024 (UTC)
* What would be the ideal case? is it that {{tl|Cn}} always displays the hota picture if there is one (I think most of the creature pics go through there)? Or is it that you can specify in various templates (e.g. <nowiki>{{Cn|Pikeman|pic=hota}}</nowiki> --[[User:Legate|Legate]] ([[User talk:Legate|talk]]) 17:30, 8 May 2024 (UTC)
** We only really need a solution for this on this template as it is coded a bit differently. With the Cn template, we can use the '''image=''' parameter, but that doesn't work in the Hero template - it isn't coded in and wouldn't make sense since there can be up to 7 creatures. I can type, for example '''Faerie Dragon (HotA)''' in one of the creature slots, but it will display '''Faerie Dragon (HotA)''' (with a red link but the correct image) and not just '''Faerie Dragon'''. I believe the solution is to either:
*** (a) add a parameter that can be used per-slot like ''' | troop_1_img= HotA''';<p>
*** (b) add a parameter that can be used per-slot like ''' | troop_1_name= Faerie Dragon'''. [[File:Hero Cosmos small.gif|link=user:phasma|→ Phasma]] 18:57, 8 May 2024 (UTC)
* Should be all set. Use "troop_#_img" with the image name you want (See the pikeman example for Adelaide on this page). --[[User:Legate|Legate]] ([[User talk:Legate|talk]]) 19:12, 8 May 2024 (UTC)
** NOTE: I didn't do anything atm with the options to have alternate hota creatures...the coding seems a little janky and I am not 100% sure what the use case is. Let me know if you need/want them. --[[User:Legate|Legate]] ([[User talk:Legate|talk]]) 19:12, 8 May 2024 (UTC)
* Wonderful! Thank you for adding this, it should be all we need! [[File:Hero Cosmos small.gif|link=user:phasma|→ Phasma]] 19:34, 8 May 2024 (UTC)